It honestly depends on your desired pace / if you want to experience more rides and experiences (food / shows / events / etc.) than just coasters. My fiancee and I just did a trip this September to Disney & Universal for food and wine / halloween and we did nearly everything we wanted. But there were a few things (resort hopping day / some bars & restaurants / SeaWorld and their coasters) that a week wasn't enough time for.
I would recommend on property if your budget allows. At Universal, staying deluxe gets you extra park time + unlimited express pass (universal skip the line) for 2 of the parks (Epic is separate) + transportation, and Disney you get extended time in the park + transportation (Note - Swan and Dolphin are Marriott but count - you CAN use points). Lightning Lane is its own deal - separate from room & ticket - but if on property you can book up to a week in advance of your first Disney day. Otherwise it’s a crapshoot if you’re going to get a pass for some of the bigger rides.
enjoy your trip!